kalkih / mini-graph-card

Minimalistic graph card for Home Assistant Lovelace UI
MIT License
2.85k stars 231 forks source link

fix: tooltip interval start could be after end #1065

Closed akloeckner closed 5 months ago

akloeckner commented 5 months ago

fixes #181

akloeckner commented 5 months ago

@ildar170975 , could you please check, if this solves your issue? According to our contributing guidelines, I'd like to have your approval also for the cleanup part. So, please also check, if your other graphs (especially using group_by) are still fine.

The js bundle should be available as described in #1064 .

ildar170975 commented 5 months ago

@akloeckner Is it this one?

image

ildar170975 commented 5 months ago

@akloeckner Tested with that js. Code from here. Seems that the issue is fixed.

ildar170975 commented 5 months ago

But I see this glitch now - no date is shown:

image

Today 28.01.24 17:44, selected a point from yesterday.

Update: no, this is an old behaviour... should be fixed too. Will prepare an issue. - DONE

akloeckner commented 5 months ago

Yes, that's the download I meant. 👍

Good to see, the original glitch seems fixed. I still don't fully understand why. I think it's something about multiplying small numbers (1/120h interval between points) with big ones (3600000ms in an hour). 🤷

Let me know, when (and if) you're confident, this could be merged!

ildar170975 commented 5 months ago

when (and if) you're confident, this could be merged!

Let's merge it... The more people will test it - the better. In my old practice (cruise missiles from 1997) even a probably tiny fix needs a full-scope testing, testers should consider a product as a "black box". But this is not a "rocket science" ))

akloeckner commented 5 months ago

:-) Agreed!

github-actions[bot] commented 3 months ago

:tada: This PR is included in version 0.12.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: