search

kalkih / mini-graph-card

Minimalistic graph card for Home Assistant Lovelace UI
MIT License
3.04k stars 236 forks source link

[Feature request] Add loading indicator #344

Open Misiu opened 4 years ago

Misiu commented 4 years ago

Recently HA added loading state to graphs: https://github.com/home-assistant/frontend/pull/5448 I think it would be a good improvement to add similar functionality here. Now you see an empty card that will show graph after some time. Showing the loading indicator will show user that something is happening and he must wait a bit longer.

This is my current setup. As you can see the current value is displayed, but it need some time to load the graph. mini_graph

kalkih commented 4 years ago

Yes, great suggestion, fetching data can be slow so a loading indicator would be nice.

Misiu commented 4 years ago

@kalkih should this be added to renderGraph function (https://github.com/kalkih/mini-graph-card/blob/master/src/main.js#L283)?

kalkih commented 4 years ago

Yes that could be a good place to add it.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. If this is still an active issue, please let us know!

ildar170975 commented 2 years ago

Could be informative.

stale[bot] commented 2 years ago

Still an active issue, got it! Removing stale label.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. If this is still an active issue, please let us know!