kalkih / mini-graph-card

Minimalistic graph card for Home Assistant Lovelace UI
MIT License
3.04k stars 235 forks source link

implement more group_by options #833

Open blind-coder opened 2 years ago

blind-coder commented 2 years ago

Implement group_by options week, month and year

minermartijn commented 2 years ago

Does this work now? I was just looking for this and now sure how to use it.

blind-coder commented 2 years ago

Does this work now? I was just looking for this and now sure how to use it.

It needs to merged, but I use it on my instance already. The grouping isn't perfect for month and year, but works solidly for week.

acmaarts commented 2 years ago

When is this expected to be released? This is just the thing I've been waiting for! 👍

stale[bot] commented 2 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

jlsjonas commented 2 years ago

Hi, There are a couple changes needed before we can integrate them though, as mentioned above. Please also rebase your changes onto the dev branch and target it instead.

Thanks a lot for your contribution! And my apologies for the slow review

blind-coder commented 2 years ago

Hello,

I have made the changes, thanks for the input. I'm not familiar with rebase and pushing afterwards, I hope I did it correctly. If not, let me know and I'll file a new PR with properly forked branches from dev.

jlsjonas commented 2 years ago

@blind-coder thanks for the changes! It looks like a few commits from master sneaked in though :) Could you interactively rebase your branch, removing the 3 readme-related commits & force push one more time? Thanks!

blind-coder commented 2 years ago

Hi Jonas,

I'm on a business trip this week and next. I'll chek it out afterwards.

Kind regards, Benjamin

stale[bot] commented 1 year ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 1 year ago

Still an active issue, got it! Removing stale label.

stale[bot] commented 1 year ago

Still an active issue, got it! Removing stale label.

stale[bot] commented 1 year ago

Still an active issue, got it! Removing stale label.

stale[bot] commented 1 year ago

Still an active issue, got it! Removing stale label.