kalkih / mini-graph-card

Minimalistic graph card for Home Assistant Lovelace UI
MIT License
2.96k stars 232 forks source link

Feature request: show time without having to show points #918

Open andyfsimon opened 1 year ago

andyfsimon commented 1 year ago

I like the graphs very much, but I don't like how it shows the points, especially when there are many per hours (like one every ten minutes). If we hide the points we lose the information about time. Would it be possible to hide the points but keep the time information visible somehow? Either by hovering with the mouse (like for the points) or with a time scale below...

image

What I don't like here is the way the points show up as circles and ruin the picture. On the other hand, if I disable the points (show_points = false) I lose the information about the time on the x axis.

ildar170975 commented 1 year ago

hide the points but keep the time information visible somehow

Please check this: https://github.com/kalkih/mini-graph-card/discussions/904

Also, FR = detailed description of some functionality. Please provide a consistent algorithm.

ildar170975 commented 1 year ago

Please provide detailed description of your proposal.

andyfsimon commented 1 year ago

904 says exactly the same thing. I cannot provide an algorithm for the same reason why I cannot do the change myself.

What me and Shasdo are proposing is that when you hover on the line, the coordinates of the mouse pointer should be enough for the card to pick up the underlying point and use it to display the relative data, without drawing a circle around all the other points which are not under the mouse pointer. You may indeed not know beforehand where all points are, but this behaviour is consistent to what the normal graph card already does.

akloeckner commented 1 year ago

I think, currently, the "tooltip" (that is showing the hovered-over data point as state) is tied to a mouse-over event of the rendered data point. So, I'm not sure this can be added easily.

Maybe, as a workaround, you can set up the points to be so small that they don't disturb the optics of the graph?

ildar170975 commented 2 weeks ago

@andyfsimon Is this issue still valid? No feedback within a year.