Closed ghost closed 10 months ago
Maybe, those lines should be more alike:
@akloeckner good find!
I believe that this was actually intended behavior, overriding only the general area, where it's unclear what entity you might want.
We could however introduce a new (boolean) property config.tap_action.everywhere
that controls the override for the 2 other lines references above.
To implement this, we'll indeed have to reference config.tap_action.entity
for the other popup triggers too, is this something you would like to try picking up?
If config
is available on those lines, it should be as simple as prepending this.entity
with (config.tap_action.everywhere && config.tap_action.entity) ||
(alongside adding the new property in the readme & config of course)
If we follow #937, we should be hesitant to add new options and interweave them with existing code.
I'll want to move on with the pending bug fixes first, before looking into this. But time is sparse currently. :-/
@ghost Deleting your posts describing the issue has no sense. Inappropriate behavior.
deleted