search

kalkih / mini-graph-card

Minimalistic graph card for Home Assistant Lovelace UI
MIT License
2.89k stars 233 forks source link

Change default branch to dev #956

Open akloeckner opened 1 year ago

akloeckner commented 1 year ago

Currently the default branch is master. This resulted in a depandabot PR targeting this branch. Sorryfor merging this into the wrong branch... This also results in people accidentally targeting the master branch in their PR, e.g., #872 .

I suggest, @kalkih change the default branch to dev.

@jlsjonas

kalkih commented 1 year ago

Changing the default branch to dev will unfortunately cause all visitors to land on the dev branch readme, could cause confusion, which is why I haven't done it. Perhaps not much of an issue anymore since there really aren't many major changes nowadays. Upside as you mentioned; all new PRs will target the correct branch, which would be sweet.

As for Dependabot, I'm not sure if we even wanna keep it, I'm personally not a fan. If we wanna keep it we could change the target branch to dev in the config.

https://github.com/kalkih/mini-graph-card/blob/210fb4c2ccdc3fe4ec95e9f6d82eb4e220405a5a/.github/dependabot.yml#L8

Let me know what you think

jlsjonas commented 1 year ago

I had the same thought process, most people visiting are not going to contribute; though we've had to explain it enough times that we should probably add a prominent section in the readme to clarify 😬

Wrt dependabot: it can be nice to keep packages updated especially in calmer cycles (as we all have too busy lives 😅) But it should definitely be reconfigured to target develop