search

kalkih / mini-graph-card

Minimalistic graph card for Home Assistant Lovelace UI
MIT License
2.89k stars 233 forks source link

"icon_image" option is added to Doc #958

Closed ildar170975 closed 1 year ago

ildar170975 commented 1 year ago

Added a "icon_image" option into Docs

ildar170975 commented 1 year ago

@akloeckner , @jlsjonas Guys, could you help me with sorting out this mess? I created a PR with adding ONE line into docs for "icon_image", then retargeted it to "dev" branch - and then I realized that this PR includes other old changes into Docs! But I only wanted to add ONE line )))

akloeckner commented 1 year ago

You could either switch to dev branch first. And then add the new line. Or cherry-pick just your last commit.

I'd suggest the first option, so starting a new PR from here: https://github.com/kalkih/mini-graph-card/tree/dev . You can then do everything in the web interface of GitHub.

Take care to:

  1. Start the commit title with doc:, so e.g. doc: add icon_image. Use the same title for your PR.
  2. Put NEXT_VERSION in the since column. (See https://github.com/kalkih/mini-graph-card/blob/94c0b8a4cb50db3f7a5f0d7b1425a9bc459c6374/MAINTAINING.md#documentation)

But, I think, this option is already documented in the dev branch.

(The mess is only because there are commits on the master branch, which are missing in dev. But that is history. We'll fix that eventually, when we merge dev into master.)

ildar170975 commented 1 year ago

@akloeckner Thanks a lot for explanations.

But, I think, this option is already documented in the dev branch.

You are right: изображение

Closing the PR.