search

kalkih / mini-media-player

Minimalistic media card for Home Assistant Lovelace UI
MIT License
1.52k stars 207 forks source link

Remove border set in HA 2022.11 #705

Closed breakthestatic closed 1 year ago

breakthestatic commented 1 year ago

Fixes #704. In Home Assistant version 2022.11, the material design language has shifted slightly and started utilizing an actual border css rule instead of the "border" intrinsically existing via the box-shadow. This fix just removes the border rule (leaving the existing box-shadow removal to be backwards-compatible with older HA versions).

tomasbedrich commented 1 year ago

LGMT. @kalkih Can it be merged please?

kalkih commented 1 year ago

Thanks for the contribution!

tomlut commented 1 year ago

This PR has removed the ability to apply a border. What happens if I want one?

breakthestatic commented 1 year ago

@kalkih probably know better, but I'm fairly certain it was never possible to manually add a border to grouped cards, and in fact, one of the primary purposes of the group variant was to explicitly remove borders (prior to this change via removal of the default box-shadow applied by Home Assistant).

Maybe open up a new issue/feature request and provide the details of what you're currently doing and what you would like to have changed?

tomlut commented 1 year ago

It was very easy using a card-mod theme class. It's fine. I'm pretty much at the point where I'm considering removing all third party cards and just using the core cards. It has become far too onerous to maintain with the constant frontend changes.

breakthestatic commented 1 year ago

Ah yeah, it's definitely difficult to directly support other third-party mods, especially one like card-mod (which provide a large amount of power/control). That being said (and I definitely also get the sentiment regarding relying on a lot of custom cards, etc.), you could probably get around this by appending !important to your css rule in card-mod.