search

kalkih / mini-media-player

Minimalistic media card for Home Assistant Lovelace UI
MIT License
1.48k stars 206 forks source link

Update fallback border-radius to latest HA style #706

Closed breakthestatic closed 1 year ago

breakthestatic commented 1 year ago

The default border-radius of ha-card is now 12px, which is causing the player contents to flow outside the card. Since the container needs overflow: visible to allow things like the source dropdown to expand beyond the player itself, it seems most appropriate to have the player contents respect the default. Perhaps this is a regression for older HA installs? Not sure what your stance is regarding maintaining backwards compatibility - worst case scenario I think is older installs could use the css variable ha-card-border-radius to override for their needs. However, I think going forward we should try to keep up-to-date with what the HA frontend is doing. Screenshot 2022-11-03 at 4 23 38 PM Screenshot 2022-11-03 at 4 28 43 PM

kalkih commented 1 year ago

Hey, Thanks for the contribution. Looks good to me.

As for backwards compatibility; I think if it's possible and not a huge hassle / much additional complexity it's great to at least aim to support the last few versions.