kalkih / simple-weather-card

Minimalistic weather card for Home Assistant
MIT License
285 stars 33 forks source link

Compatibility with Home Assistant Community Store #10

Closed mjoshd closed 5 years ago

mjoshd commented 5 years ago

The Home Assistant Community Store is really awesome and helps greatly in managing custom cards/components/etc. but this custom card is incompatible ☹️

2019-06-23 13:48:14 [custom_components.hacs.hacs] kalkih/simple-weather-card - No acceptable js files found
2019-06-23 13:48:14 [custom_components.hacs.hacs] kalkih/simple-weather-card - Could not register.

Please make it compatible: https://custom-components.github.io/hacs/developer/plugin/

royto commented 5 years ago

I made a pr on hacs to support it but was rejected. It is due to bundle name. This PR should fix it

kalkih commented 5 years ago

Merged https://github.com/kalkih/simple-weather-card/pull/9, HACS will be supported in the next release, will also submit a PR after next release to have the card available by default in HACS.

kalkih commented 5 years ago

Should now be available in HACS https://github.com/custom-components/hacs/pull/219 🎉

mjoshd commented 5 years ago

Installed via HACS and it's working great! Thanks 😀

timdonovanuk commented 5 years ago

Installed via HACs and it's not working great :(

No card type found

I have added it to my raw config:

- type: module url: /community_plugin/simple-weather-card/simple-weather-card-bundle.js

and ensured the file exists at /community_plugin/simple-weather-card/simple-weather-card-bundle.js

timdonovanuk commented 5 years ago

Ah..the example is just badly formatted. Doh!

type: custom:simple-weather-card
entity: weather.dark_sky
name: in current location

rather than:

- type: custom:simple-weather-card
  entity: weather.dark_sky
  name: in current location

Thanks, lovely plugin :)

kalkih commented 5 years ago

You identified the issue, great! Yes, the examples are formatted for raw config editor / lovelace in yaml mode, as the GUI editor will automatically add the initial dash in the card config.

timdonovanuk commented 5 years ago

Ah, is that what that is! I've now noticed a lot of peoples examples had that dash. Got your weather in my dashboard now and it's looking fabulous, thanks again :)