kalkih / simple-weather-card

Minimalistic weather card for Home Assistant
MIT License
283 stars 33 forks source link

Add Dark Sky icon values and resolve issue when using custom icon-state #31

Closed pmosbach closed 4 years ago

pmosbach commented 4 years ago

I started the branch to merely add additional values to ICONS to cover values that the Dark Sky API returns that were not already present. In testing, after switching to a custom icon-state and pointing that to a sensor for the Dark Sky icon, the appropriate icon was not rendered despite a matching key in ICONS. After further investigation, I realized the call to getIcon(...) was returning undefined because the icon-state object was being passed in rather than just the state value of the icon-state object. This may help with other instances where a custom icon-state is used (as discussed in #8)

kalkih commented 4 years ago

Thanks, great spotted!