search

kalkih / simple-weather-card

Minimalistic weather card for Home Assistant
MIT License
283 stars 33 forks source link

Use the right element to get LitElement from #50

Closed bramkragten closed 3 years ago

bramkragten commented 3 years ago

The home-assistant element is not a normal LitElement, but has a bunch of mixins giving unwanted side effects.

Besides that, hui-view is no longer a LitElement but a UpdatingElement, so should not be used as a fallback.

kalkih commented 3 years ago

Great, thanks!

hmmbob commented 3 years ago

@kalkih could you possibly tag a new release with this fix? Without it, the card is making my theme revert to dark mode everytime the card is displayed 😉

I only have seen the issue on 2021.5.0 beta release so far, which makes me believe more users will be affected as soon as 2021.5 ships (coming Wednesday).

Thanks for creating great stuff!

kalkih commented 3 years ago

Hey @hmmbob , thanks for letting me know, will create a release later today 👍

hmmbob commented 3 years ago

Much appreciated, thanks!

Mariusthvdb commented 3 years ago

@kalkih could you possibly tag a new release with this fix? Without it, the card is making my theme revert to dark mode everytime the card is displayed 😉

I only have seen the issue on 2021.5.0 beta release so far, which makes me believe more users will be affected as soon as 2021.5 ships (coming Wednesday).

Thanks for creating great stuff!

yes! thats exactly what I saw yesterday, couldn't find the logic to it though...more-over it doesnt do that right now, so some mystery still going on...

@bramkragten please allow me to ask if that is something that needs to be changed here and here in custom-ui too?

bramkragten commented 3 years ago

@bramkragten please allow me to ask if that is something that needs to be changed here and here in custom-ui too?

No.