rename bundle filename - Githubissues

kalkih / simple-weather-card

Minimalistic weather card for Home Assistant

MIT License

285 stars 33 forks source link

rename bundle filename #9

Closed royto closed 5 years ago

royto commented 5 years ago

change to simple-weather-card-bundle.js

coherent with your other cards
support for hacs (see my rejected PR https://github.com/custom-components/hacs/pull/153)

kalkih commented 5 years ago

Thanks!

Yeah, I would actually prefer if all my card releases were named .bundle.js instead of -bundle.js, that's why I went with this new naming convention for this new(er) card. I Didn't want to change the old cards since that would break stuff.

But since -bundle now seems to be hardcoded into HACS I guess we should go a head and apply the same naming convention here for simplicity's sake.

kalkih commented 5 years ago

I'll submit a PR to have this card available by default in HACS, thanks for the heads up!