search

kalkun-sms / Kalkun

Open Source Web based SMS Manager
https://kalkun.sourceforge.io/
GNU General Public License v2.0
213 stars 130 forks source link

update requirement check & session_save_path #401

Closed tenzap closed 2 years ago

tenzap commented 2 years ago

As per CI doc, it is not good practice to set sess_save_path to a world writable dir like a tmp/temp dir. So set the value back to it default value which is NULL. When it is NULL, it will use the value of PHP's session_save_path() which is normally set. At least on debian it is well set to /var/lib/php/sessions.

At install time, it is checked whether the path used to store the sessions by CI is writable. If not, it tells the user to set the value in the config.php file.

BTW, update requirement check for some extensions that weren't listed

tenzap commented 2 years ago

Shall we also remove the creation of the ci_session table in the database during setup? Kalkun is setup to use the "files" driver so this table is useless. If the user want's to use that driver, maybe he should set it up on his own.

tenzap commented 2 years ago

What about this one?

tenzap commented 2 years ago

Shall we also remove the creation of the ci_session table in the database during setup? Kalkun is setup to use the "files" driver so this table is useless. If the user want's to use that driver, maybe he should set it up on his own.

kingster commented 2 years ago

Let's keep that for now. Ideally, the right place for the sessions would be something like redis / some db which supports TTL so that auto cleanup can happen. Using files for session storage limits any application from having multiple deployments.