kalkun-sms / Kalkun

Open Source Web based SMS Manager
https://kalkun.sourceforge.io/
GNU General Public License v2.0
209 stars 129 forks source link

Include vendor directory in dist.zip #441

Closed kingster closed 2 years ago

kingster commented 2 years ago

Fixes #440

tenzap commented 2 years ago

Looks like it contains also the require-dev components. This makes a very big archive.

Could we only ship those that are in require?

The full debian packages with all dependencies take 3.3MB

tenzap commented 2 years ago

Just wondering... How would you do to get the dependencies for a system (typically for the demo on sourceforge) that runs PHP 7.1 when running a different php version?

kingster commented 2 years ago

For demo can't we run composer install and let composer pull in dependency based on php version?

tenzap commented 2 years ago

no internet access on sourceforge, no composer binary...

tenzap commented 2 years ago

https://github.com/composer/composer/issues/10625

tenzap commented 2 years ago

Anyway, looks like we have to build multiple dists, for a few selected versions of PHP

tenzap commented 2 years ago

fixed by #450 & #455