search

kalkun-sms / Kalkun

Open Source Web based SMS Manager
https://kalkun.sourceforge.io/
GNU General Public License v2.0
209 stars 129 forks source link

set default CI_ENV to production #446

Closed tenzap closed 2 years ago

tenzap commented 2 years ago

See: https://codeigniter.com/userguide3/general/environments.html

tenzap commented 2 years ago

I'm having some doubt on whether we should enable this by default. Maybe we should let the user do?

Setting this will make the error Dialog Show empty messages because errors like 500, 400, 404... Will not display anything, not even a word.

What do you think?

kingster commented 2 years ago

One thing that we can do, is that we add the option with default to 'Development' and then let the user change the configuration.

tenzap commented 2 years ago

Ok, and what do you think on either option? Which one to set now? Leave it to development and let the user doing when installed by advising him to do so?

(BTW, what about #443 & #439?)

kingster commented 2 years ago

Let's have 'Development' as default.

Responded on the other pr's

tenzap commented 2 years ago

thanks. done.