search

kalkun-sms / Kalkun

Open Source Web based SMS Manager
https://kalkun.sourceforge.io/
GNU General Public License v2.0
209 stars 129 forks source link

Don't use PREG_UNMATCHED_AS_NULL. Since it appeared in PHP 7.2 #453

Closed tenzap closed 2 years ago

tenzap commented 2 years ago

Fixes this error message: Use of undefined constant PREG_UNMATCHED_AS_NULL - assumed 'PREG_UNMATCHED_AS_NULL'

kingster commented 2 years ago

Instead of completely removing this, can't we split the logic based on php version? That way when we remove old php version support we can cleanly remove old logic

tenzap commented 2 years ago

Too complex for no benefit. Moreover I prefer to keep compatibility with 5.6 at least for 0.8 so that those running old versions can still have a refreshed kalkun.

tenzap commented 2 years ago

Can you please "remove the outdated check in the protected branch settings of the repository settings. " so that waiting jobs can restart?

tenzap commented 2 years ago

What about this one here?

tenzap commented 2 years ago

What about approval then? Should I wait for it or not? Btw I initially wrote this plug-in. The use of the constant doesn't bring anything interesting.

kingster commented 2 years ago

Have approved for now. But as I mentioned we should add todo and switch back when we drop php 5.6 support

tenzap commented 2 years ago

But it is not available in 7.0 either... Neither 7.1...

tenzap commented 2 years ago

I still don't see the point sorry.