Closed alexandergotts closed 5 months ago
Please check https://github.com/kalkun-sms/Kalkun/pull/512 Is your PR still required?
Please check #512 Is your PR still required?
I think my pr is no longer needed
When doing squash & merge, use this commit message:
remove deprecated call to CI_Model::__construct()
In future CI3 version 3.2.0, that constructor is entirely removed,
which would result in fatal errors on attempts to call it.
See: https://github.com/bcit-ci/CodeIgniter/blob/develop/user_guide_src/source/installation/upgrade_320.rst
get_class() not working with php 8.3
Shouldn't we remove the construct function itself? If there is nothing inside it?
Shouldn't we remove the construct function itself? If there is nothing inside it?
That's what I meant in my comment above https://github.com/kalkun-sms/Kalkun/pull/510#discussion_r1489547772
Could work but it also works if you just leave it empty
Could you please squash all the commits to leave only these two and set an appropriate commit message?
__CLASS__
)Could you please squash all the commits to leave only these two and set an appropriate commit message?
- one commit for the changes related to the constructor for CI3.2. I think it is cleaner to remove completely the empty constructors.
- one commit for the changes related to php 8.3 (
__CLASS__
)
I can only make one fork that I can commit
You probably need to use the command line for that.
Search for "git squash commit" in a search engine.
it's done
Thanks
Replaced by #513 & #514
updates codeigniter/framework to be compatible for php 8.2+ and removes fix that no longer works