search

kallaballa / MidiPatch

MidiPatch is a scriptable and modular real-time software synthesizer using the PatchScript API
GNU Affero General Public License v3.0
12 stars 2 forks source link

Fork Tonic, merge stale PR's? #123

Open seclorum opened 4 years ago

seclorum commented 4 years ago

Tonic seems to have a number of decent Pull Requests which contain fixes and enhancements of some value:

https://github.com/TonicAudio/Tonic/pulls

.. but these have not been addressed since 2016. Perhaps we ought to fork Tonic and apply these changes to the Fork as well? The license seems to permit it ..

Alternatively, we could ask the Tonic devs whats going on, since its a significant dependency for us ..

kallaballa commented 4 years ago

I did already fork it but the fork is not up to date with Tonic in PatchScript/third anymore: https://github.com/kallaballa/Tonic

Can't take over maintaining tonic as well at the moment. Anyway this is going to be important at some point. I'll look into the pull requests

seclorum commented 4 years ago

I get that, but maybe we should prioritise pulling in those stale PR's, there are some decent fixes in there, like:

https://github.com/TonicAudio/Tonic/pull/272

.. anyway I have reached out to the Tonic authors to see if they have plans to merge their PR's (and test of course), and if that happens we should refresh the fork. Stay tuned.

kallaballa commented 4 years ago

Cool, thx