search

kallaballa / ctrl-cut

Get your laser cutter under control
GNU General Public License v2.0
63 stars 7 forks source link

Make editing of spinboxes more sensible #7

Closed kallaballa closed 10 years ago

kallaballa commented 10 years ago

Doing a single edit (one key stroke) in a qspinbox will emit valueChange and the component loses the focus. Instead it should wait for either the return key being hit or for lost focus before commiting the change.

kintel commented 10 years ago

This bug is caused by temporarily disabling GUI elements in ObjectPropertyWidget::disable(): https://github.com/Metalab/ctrl-cut/blob/master/src/gui/ObjectPropertyWidget.cpp#L235

disabling the elements causes them to lose focus.

kallaballa commented 10 years ago

but disable is not called in the pertaining slots. e.g. https://github.com/Metalab/ctrl-cut/blob/master/src/gui/ObjectPropertyWidget.cpp#L256

kintel commented 10 years ago

It is. Follow the trail starting at https://github.com/Metalab/ctrl-cut/blob/master/src/gui/ObjectPropertyWidget.cpp#L58

kallaballa commented 10 years ago

you were right. fixed