search

kallemooo / Asap2

Asap2 parser.
MIT License
38 stars 21 forks source link

Update to SDK style projects and add .NET Standard 2.0 target #18

Open ngbrown opened 1 year ago

ngbrown commented 1 year ago

This replaces #17

All projects were updated to SDK style projects.

Updating to YaccLexTools version 1.0.0 enabled building in SDK style projects. It also changed the exposed QUT.GplexBuffers classes. This may be considered an API break, or it may be ignored. Right now I set the version to 2.0.0.

Also different from the other pull request, is that this enables multi-targeting, so the NuGet package will have multiple versions of the DLL for different runtimes.

The GitHub actions were all updated to the most recent versions and caching was added. I also set the version of the DLL within the build step.

ngbrown commented 1 year ago

The part of the check that is failing is this action to release on latest:

https://github.com/kallemooo/Asap2/blob/559bcd54249a68dbb30ea669daacd9e6e1cf2108/.github/workflows/build.yml#L59-L68

I don't know what the goal of this step was, but it seems like re-releasing on the same tag repeatedly doesn't work. Also, it doesn't seem like a good idea to do this within pull requests. It should only be done on commits to master.

kallemooo commented 1 year ago

The part of the check that is failing is this action to release on latest:

https://github.com/kallemooo/Asap2/blob/559bcd54249a68dbb30ea669daacd9e6e1cf2108/.github/workflows/build.yml#L59-L68

I don't know what the goal of this step was, but it seems like re-releasing on the same tag repeatedly doesn't work. Also, it doesn't seem like a good idea to do this within pull requests. It should only be done on commits to master.

The idea is to have a "latest beta-release" automatically created. But it should only be done on master... So the rule should be updated to not include branches. Or removed as it seems not to work properly, and the github repo have not been updated the latest two years. Should probably be replaced with an action based on softprops/action-gh-release

sven-n commented 3 months ago

Hi, any news here?