search

kallepersson / inboxtheme

Brings the Google Inbox experience to Gmail
http://flowapps.co/inboxtheme
MIT License
88 stars 10 forks source link

Trash and Spam links broken #45

Open kallepersson opened 5 years ago

kallepersson commented 5 years ago

I'm using your plugin for Chrome and noticed that clicking on Trash or Spam on the left side do nothing. Could you please fix?

jarekwg commented 5 years ago

It looks to me like they're only 'broken' if the labels are disabled in settings. What happens in this case, is that these links aren't visible on the left, until the menu is expanded. When expanded, the items shuffle themselves into position, and then stay there even after the menu is minimised. eg. With these settings: image I see this initially: image Then this after expanding: image Then this after minimising again: image However, regardless of whether the menu is expanded or not, Draft/Sent/Trash/Spam don't do anything when marked as hidden in settings.

You recommend switching on all labels, but perhaps, if someone has Drafts/Sent/Trash/Spam/etc switched off, just don't show these (by detecting whether they appear in main section or in 'more' section (more section == switched off, so don't bother with them))?

bstmedia commented 5 years ago

I like to have "trash" hidden as well. A workaround is to type "in:trash" into search. Thats actually faster for me than clicking "More > Trash".