search

kallerosenbaum / grokkingbitcoin

Source repository for Grokking Bitcoin
https://www.manning.com/books/grokking-bitcoin
Other
258 stars 54 forks source link

Problem with the images #2

Closed ghost closed 5 years ago

ghost commented 5 years ago

Images aren't being shown. Can't view any of them while reading though the chapters.

kallerosenbaum commented 5 years ago

This is known, and not actually an issue, since it's by design. The content is not currently readable directly on GitHub. If you want to view the content, go to http://rosenbaum.se/book where I serve the generated book content.

The reason for it not being readable on github is that the images are in .eps format in git. To make the required .svg images the book has to be built using make on a linux machine (see https://github.com/kallerosenbaum/grokkingbitcoin/blob/master/readme.md). Eps is used because that's the actual source format that Manning uses. I think we need to keep the .eps files out of (at least) printing reasons. If we one day make a 2nd edition, we will need .eps.

I'm closing this for now, but I do agree that it'd be neat to browse the content directly on GitHub.