kallerosenbaum / grokkingbitcoin

Source repository for Grokking Bitcoin
https://www.manning.com/books/grokking-bitcoin
Other
255 stars 53 forks source link

Wrong name in Chapter 8 #26

Closed srivathsanvenkateswaran closed 2 years ago

srivathsanvenkateswaran commented 2 years ago

Alice sends money to Bob using a transaction. But instead of Alice, It's mentioned that the money comes out of John's wallet.

kallerosenbaum commented 2 years ago

Thanks for your report. Where in chapter 8 is this?

srivathsanvenkateswaran commented 2 years ago

Screenshot from 2022-02-18 00-06-14

In the paragraph below Figure 1

srivathsanvenkateswaran commented 2 years ago

In the figure, It's Alice who is sending money to Bob. But in the paragraph which follows the figure, it's mentioned that the money comes out of John's wallet. That's what I meant.

srivathsanvenkateswaran commented 2 years ago

If you want I'll edit the name and submit a PR.

kallerosenbaum commented 2 years ago

Ok, I see what you mean. But the error is the other way around: The paragraph speaks about the transaction from John to the Café, but it mistakenly says that Bob is the recipient: "with Bob's wallet being notified" should be "with the cafe's wallet being notified".

Admittedly, it's a bit confusing that we talk about a John->cafe when the picture right above is about Alice->Bob. The picture is an overview picture that we've used through every chapter as a map of what the chapter will cover, the "You are here" annotations. I'll make a fix.

Thanks so much for reporting this!

srivathsanvenkateswaran commented 2 years ago

Well, it's my duty to report you! After all, you've helped me a lot in understanding the Bitcoin Protocol. That too for free [couldn't afford printed copy :( ]

Thanks a lot, man... From the bottom of my heart!!

kallerosenbaum commented 2 years ago

@srivathsanvenkateswaran You're most welcome. I love that you can read the book for free, that's far more rewarding to me than the small bucks i get for each sale. Open source is the way.