search

kalliope-project / kalliope

Kalliope is a framework that will help you to create your own personal assistant.
https://kalliope-project.github.io/
GNU General Public License v3.0
1.71k stars 229 forks source link

Idle and Wakeup enhancement #646

Closed 1001111github closed 3 years ago

1001111github commented 3 years ago

Please refer to CHANGELOG.md. As an old tie diff and patch guy this is my first git pull request. Please feel free to correct or guide me in the proper way to do this.

Thanks Dave

Sispheor commented 3 years ago

On Github we usually:

I have no idea what you are trying to do here.

1001111github commented 3 years ago

I do not have the time

1001111github commented 3 years ago

Hi Nicolas, I didn't want to leave all the unanswered questions

On 2020-11-24 10:29 a.m., Nicolas Marcq wrote:

+

  • add thread to interrupt when sleeping

  • self.Wakeup = Event()

Yes I can see that you've imported Event. What I mean is that you use only the "Thread' behavior of the Event object as it's a parent object https://github.com/kalliope-project/kalliope/blob/master/kalliope/signals/event/event.py#L12. You don't need to instantiate an Event object here but a simple native thread.

After reading up on it I think I need Event as I am waking up the thread from outside the object that owns the thread. I believe I use the set(), clear() and wait() calls from threading.Event

I'm sorry but the time required to do the time variables properly is not worth it to me at this time. I have spent 2-3 hours on SettingLoader and the Model and all the rest and still have not put it together. Functionality is my primary driver at this point and since the Linux phones are bleeding edge once I have something running it's on to the next thing. In this case a neuron, Closest. "Where is the closest " I also have to integrate Contacts into the Phone neuron,

Thank you very much for your time and effort on Kalliope as well as your tutoring of me today. I am extremely impressed with your work as I found your code extremely readable and understandable. I literally had no python knowledge before I started with Kalliope and I would have found it far more difficult with the quality code I usually have to deal with

Sincerely, Dave

-- Dave Morgan Senior Consultant, 1001111 Alberta Limited dave.morgan@1001111.com 403 399 2442