kalliope-project / kalliope

Kalliope is a framework that will help you to create your own personal assistant.
https://kalliope-project.github.io/
GNU General Public License v3.0
1.71k stars 229 forks source link

Update Werkzeug #666

Closed corus87 closed 2 years ago

corus87 commented 2 years ago

Installation will fail, because of werkzeug 0.16.1

error: Werkzeug 0.16.1 is installed but Werkzeug>=2.0 is required by {'flask', 'Flask'}
corus87 commented 2 years ago

Travis failed on docker and Debian on python 3.6. Since we are on 3.7 and those test passed, this should be good @Sispheor ?

Sispheor commented 2 years ago

Yes it fails only in docker install. I need to check why. Seems related to Ansible.

Sispheor commented 2 years ago

Could you try to add this to each dockerfile?

ENV LANG en_US.UTF-8
ENV LC_ALL en_US.UTF-8
Sispheor commented 2 years ago

The weird thing is that, following first research on Google, it's related to python 3.6. But, the version of Ansible package is hard coded so I don't understand why we have the issue now.

Sispheor commented 2 years ago

I don't understand how you get this message. The Flask version is supposed to be < 2.

error: Werkzeug 2.0.1 is installed but Werkzeug<2.0,>=0.15 is required by {'flask', 'Flask'}
corus87 commented 2 years ago

Oh just noticed your fix.... I've changed the install method to use pip instead of easy_install, lets see what travis say.

corus87 commented 2 years ago

I don't understand how you get this message. The Flask version is supposed to be < 2.

error: Werkzeug 2.0.1 is installed but Werkzeug<2.0,>=0.15 is required by {'flask', 'Flask'}

Not sure either right now. But I've got this message in a virtual env using Python 3.8.

Sispheor commented 2 years ago

I fixed dependencies issue. But now I have a failing test.

corus87 commented 2 years ago

I fixed dependencies issue. But now I have a failing test.

But I still get the SandboxViolation error on the fix-install branch in a virtual env?

Also with ansible 4.5 the dict key has changed to "vault_pass"

otherwise you get this error,

fatal: [localhost]: FAILED! => {"msg": "timeout waiting for privilege escalation password prompt:\n"}

when we try to install a neuron.

Sispheor commented 2 years ago

As expected, switching from Ansible 2.9 to 4.x need some refactoring...

corus87 commented 2 years ago

Just tested your fix-install branch on a fresh installed Ubuntu 20.04 VM.

First I got this error:

Installed /usr/local/lib/python3.8/dist-packages/aniso8601-9.0.1-py3.8.egg
Searching for itsdangerous>=2.0
Reading https://pypi.org/simple/itsdangerous/
Downloading https://files.pythonhosted.org/packages/9c/96/26f935afba9cd6140216da5add223a0c465b99d0f112b68a4ca426441019/itsdangerous-2.0.1-py3-none-any.whl#sha256=5174094b9637652bdb841a3029700391451bd092ba3db90600dea710ba28e97c
Best match: itsdangerous 2.0.1
Processing itsdangerous-2.0.1-py3-none-any.whl
Installing itsdangerous-2.0.1-py3-none-any.whl to /usr/local/lib/python3.8/dist-packages
Adding itsdangerous 2.0.1 to easy-install.pth file

Installed /usr/local/lib/python3.8/dist-packages/itsdangerous-2.0.1-py3.8.egg
error: Click 7.0 is installed but click>=7.1.2 is required by {'Flask', 'flask'}

after sudo pip3 install click==7.1.2 it continues to install but ends also with the SandboxViolation Error

My pr installed without problems. Is there a reason why we cannot install the dependencies with pip as I do in my pr?

As expected, switching from Ansible 2.9 to 4.x need some refactoring...

As far as I can tell, for our needs we only need to change the dict key to vault_pass.

Sispheor commented 2 years ago

Ok to install via pip if it's supported by setup.py. But we still need to bumb flask as well if we use warzeug 2.0

Sispheor commented 2 years ago

Oh I haven't seen that you've updated flask as well. We need to fix that test and we're good I guess

Sispheor commented 2 years ago

I have updated my PR with your changes concerning lib install.

corus87 commented 2 years ago

I have updated my PR with your changes concerning lib install.

Sounds good.

Sispheor commented 2 years ago

Fixed in another PR. I close this one