search

kallookoo / wp-color-picker-alpha

Overwrite Automattic Iris for enabled Alpha Channel in wpColorPicker
GNU General Public License v2.0
131 stars 88 forks source link

fix for issue #35 : WP >= 5.5 error : Uncaught ReferenceError: wpCol… #38

Closed prince5ingh closed 3 years ago

prince5ingh commented 3 years ago

…orPickerL10n is not defined

wpexplorer commented 3 years ago

That was quick! Awesome ;)

shivapoudel commented 3 years ago

@prince5ingh Tested! work fine in my end 💯

prince5ingh commented 3 years ago

@wpexplorer @shivapoudel thankyou guys !, glad it worked :)

rilwis commented 3 years ago

@prince5ingh Can you please update the PR according to @shivapoudel's comments? We need to make sure it works for both WP 5.5 and below.

Thanks!

prince5ingh commented 3 years ago

@rilwis here is the updated pull request with some changes suggested by @shivapoudel

https://github.com/kallookoo/wp-color-picker-alpha/pull/38

rilwis commented 3 years ago

@prince5ingh I'm not a reviewer, but I think you should check the first comment. It's crucial for backward compatibility.

kallookoo commented 3 years ago

Hi,

Thanks @prince5ingh for this PR, but not support older version of the WordPress and therefore I close it