kallqvist / skillshare-downloader

MIT License
313 stars 105 forks source link

Just first video downloaded #3

Closed alitekdemir closed 6 years ago

alitekdemir commented 6 years ago
Traceback (most recent call last):
  File "J:\Downloads\AverageSpatialSearch\main.py", line 10, in <module>
    dl.download_course_by_url('https://www.skillshare.com/classes/How-to-Make-Apps-with-No-Programming-Experience/1960310793')
  File "downloader.py", line 24, in download_course_by_url
    self.download_course_by_class_id(m.group(1))
  File "downloader.py", line 63, in download_course_by_class_id
    raise Exception('Failed to read video ID from data')
Exception: Failed to read video ID from data

I can not solve this problem. May be you can solve??

kallqvist commented 6 years ago

Hmm.. Does this happen also for other courses or is it just this one? If it's all of them it might be something wrong with your cookie.

Otherwise I'm not sure, I no longer have an account with skillshare so this code is not maintained or tested for a long time now... :/

alitekdemir commented 6 years ago

if you want to test again, I can share my account with you :) and thank you for your codes..

kallqvist commented 6 years ago

Sure, you can send an email to kallqvist@gmail.com and I'll take a look at it :)

pete-murphy commented 6 years ago

Any luck with this? I get:

Building ssdl
Step 1/6 : FROM python:2.7-slim
 ---> e55f998ecc76
Step 2/6 : RUN pip install requests
 ---> Using cache
 ---> 54c15403b25d
Step 3/6 : COPY ./code /code
 ---> f96d6babc2c6
Step 4/6 : WORKDIR /code
Removing intermediate container 7265f9b5424e
 ---> 1ea38b6f31c4
Step 5/6 : RUN chmod +x from-arguments.py
 ---> Running in c879751a5003
Removing intermediate container c879751a5003
 ---> b0597630a4f2
Step 6/6 : ENTRYPOINT ["python", "/code/from-arguments.py"]
 ---> Running in 2618f63b5b07
Removing intermediate container 2618f63b5b07
 ---> 5d6f90836043
Successfully built 5d6f90836043
Successfully tagged skillshare-downloader_ssdl:latest
Traceback (most recent call last):
  File "/code/from-arguments.py", line 14, in <module>
    dl.download_course_by_url(sys.argv[2])
  File "/code/downloader.py", line 23, in download_course_by_url
    raise Exception('Failed to parse class ID from URL')
Exception: Failed to parse class ID from URL
sandy2711323 commented 6 years ago

where are the videos downloaded i mean the download location ?

kallqvist commented 6 years ago

hey guys, sorry about all the silence from my end! busy work have kept me away from github...

default download location in code is set to /data this will most likely be an issue if you happen to try to run this on a windows machine

I really, really do recommend anybody reading this to consider running it with docker and the docker-compose.yml project file in the repo. That is how this all was developed and intended to be used.

Anyway, changing download path is pretty easy. Edit the code and pass your path to the downloader class like this:

...
dl = Downloader(cookie=cookie, download_path='c:\path to downloads')
...

I only have mac/linux computers and can't test any of this on a windows machine. Also; I don't even use or have a premium skillshare account anymore so sadly, I can't test any of this on any computer at all. As far as development and improvements from my end is concerned I consider this project to be "dead", I'll leave the code online if anyone else happens to be interrested to see if it still works or maybe take on future development.

kallqvist commented 6 years ago

Oh; and for all that needs the ability to view skillshare courses offline but doesn't want to get their hands dirty writing code I know that there's also this project that might be a bit more stable and user-friendly: https://github.com/tharyckgusmao/Skill-Share-Crawler---DL

My project is not a ready and user-friendly application for people to use, I don't have any relation or experience from this other project I'm linking to but just from the looks of it I'd say it's a more feature-rich and user-friendly projekt