search

kalmarek / KnuthBendix.jl

Pure Julia implementation of the Knuth-Bendix completion (focused primarily on groups and monoids)
MIT License
8 stars 2 forks source link

Fix/simplifyrule! #41

Closed kalmarek closed 3 years ago

kalmarek commented 3 years ago

The bug in #40 has probably nothing to do with BufferWords, but is most probably an off-by-one index in simplifyrules!.

Closes #40

codecov-io commented 3 years ago

Codecov Report

Merging #41 (ba820ce) into kbs2_updates (affc7f3) will decrease coverage by 0.05%. The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           kbs2_updates      #41      +/-   ##
================================================
- Coverage         93.12%   93.07%   -0.06%     
================================================
  Files                12       12              
  Lines               742      751       +9     
================================================
+ Hits                691      699       +8     
- Misses               51       52       +1
Flag Coverage Δ
unittests 93.07% <100.00%> (-0.06%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/rewriting.jl 93.90% <100.00%> (+0.75%) :arrow_up:
src/bufferwords.jl 98.93% <0.00%> (-1.07%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update affc7f3...ba820ce. Read the comment docs.

kalmarek commented 3 years ago

most probably: lack of test cases ;) anyway: moving on (and the fact that only BufferWords are fed to simplifyrule! in normal operation)