search

kalmarek / SymbolicWedderburn.jl

Amazing package to compute decompositions into irreducibles of explicit group representations and the Wedderburn decomposition for endomorphisms thereof!
MIT License
9 stars 4 forks source link

floor(Int, sqrt) -> isqrt #16

Closed blegat closed 3 years ago

blegat commented 3 years ago

~One difference is that before this PR, it was converting to while here it keeps the same integer type~ I convert to Int for the reason detailed in comment

codecov[bot] commented 3 years ago

Codecov Report

Merging #16 (fc52d53) into master (1fac35e) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #16   +/-   ##
=======================================
  Coverage   72.10%   72.10%           
=======================================
  Files           9        9           
  Lines         276      276           
=======================================
  Hits          199      199           
  Misses         77       77
Flag Coverage Δ
unittests 72.10% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/dixon.jl 97.43% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6248dbc...fc52d53. Read the comment docs.

blegat commented 3 years ago

Anything blocking the merge ?