search

kalmarek / SymbolicWedderburn.jl

Amazing package to compute decompositions into irreducibles of explicit group representations and the Wedderburn decomposition for endomorphisms thereof!
MIT License
9 stars 4 forks source link

InducingHomomorphism type piracy #22

Closed blegat closed 3 years ago

blegat commented 3 years ago

Defining a constructor for InducingHomomorphism with a vector of monomial outside of this package is type piracy, I would suggest something like

(::InducingHomomorphism)(::AbstractVector{<:AbstractMonomial}, ::AbtractAcction)

If a package defines a subtype of AbtractAcction, it can define a method without type piracy. Fixing this might be done at the same time as fixing https://github.com/kalmarek/SymbolicWedderburn.jl/issues/21

kalmarek commented 3 years ago

@blegat resolved by #25?

blegat commented 3 years ago

Yes :)