Closed kalmarek closed 3 years ago
Merging #25 (e84e826) into master (98e56d0) will decrease coverage by
2.63%
. The diff coverage is83.33%
.
@@ Coverage Diff @@
## master #25 +/- ##
==========================================
- Coverage 91.17% 88.53% -2.64%
==========================================
Files 10 10
Lines 442 445 +3
==========================================
- Hits 403 394 -9
- Misses 39 51 +12
Flag | Coverage Δ | |
---|---|---|
unittests | 88.53% <83.33%> (-2.64%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
src/SymbolicWedderburn.jl | 100.00% <ø> (ø) |
|
src/characters_arith.jl | 25.00% <0.00%> (-46.43%) |
:arrow_down: |
src/characters.jl | 75.51% <67.64%> (+1.43%) |
:arrow_up: |
src/actions.jl | 91.66% <100.00%> (ø) |
|
src/dixon.jl | 98.18% <100.00%> (+0.03%) |
:arrow_up: |
src/eigenspacedecomposition.jl | 93.87% <100.00%> (-0.07%) |
:arrow_down: |
src/gf.jl | 94.02% <100.00%> (ø) |
|
src/projections.jl | 84.21% <100.00%> (-10.24%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 98e56d0...7065316. Read the comment docs.
@blegat I'll merge this but it'd be best to meet and chat about ScaledPerm
etc. ;)
VirtualCharacter
s nowaction_character
and use orthogonality of characters to figure out its constituents : no unnecessary(=zero) projection will be ever computedsymmetry_adapted_basis(G, basis, action)
the user provides the action as a functionaction(b, g) → b'
forb,b'∈ basis
andg ∈ G
. No need to extend/pirate anything, closing #22 ? with this method a call for polynomial basis is structured aspermuted
) is stored inExtensionHomomorphism
, which hopefully will allow us to use it for other actions than permutation ones ;)