search

kalmarek / SymbolicWedderburn.jl

Amazing package to compute decompositions into irreducibles of explicit group representations and the Wedderburn decomposition for endomorphisms thereof!
MIT License
9 stars 4 forks source link

row or column based direct summands? #39

Open kalmarek opened 3 years ago

kalmarek commented 3 years ago

@blegat I think we just happen to do it row-based by a historical accident now (row_echelon_form). I think all of this should be rewritten to column_echelon_form anyway, but this is just internals; users will face row-based symmetry_adapted_basis I think it should be changed to column-based. Any objections?

blegat commented 3 years ago

I use the fact that the output is in row-echelon here: https://github.com/jump-dev/SumOfSquares.jl/blob/master/src/Certificate/Symmetry/wedderburn.jl#L111 However, if it's just internal and the users get a row-based one I have no objection