kaloz / mwlwifi

mac80211 driver for the Marvell 88W8864 802.11ac chip
395 stars 119 forks source link

Please Mu-Mimo. #296

Open adamcarter1 opened 6 years ago

adamcarter1 commented 6 years ago

Thank you

Keltere commented 6 years ago

yuhhaurlin wrote this 17 days ago

It is under working. However, other jobs will interrupt this working sometimes, but this feature will be added finally.

Based on the complexity of the job, this statement and the long wait for previous updates i think we will wait several month if not even a year before we get Mu-Mimo. Anyway some updates on the status of works will be appreciate by the community.

thagabe commented 6 years ago

@adamcarter1 I recommend picking up a better supported Open Source router. Marvell has consistently shown their complacency regarding this driver. They have only assigned one person for this project and now they are cutting into his time to make him work in another project. This driver will never be feature parity with the closed source driver. After following and testing this driver since the original WRT1900AC and now with a WRT3200ACM, I have finally given up on this driver being truly open sourced or being on par with the closed driver. It's unfortunate as the WRT line was so beloved by the open source community. Belkin tried to revive it but chose Marvell who clearly do not care about open source. If you can sell or return this router I suggest you do. Best of luck -G

yuhhaurlin commented 6 years ago

No. Marvell will support this driver.

yuhhaurlin commented 6 years ago

Trace of MU-MIMO is done. We will complete it ASAP.

BrainSlayer commented 6 years ago

@thagabe : but you should consider that no opensource router yet does support MU-MIMO. so marvell would be still the first

yuhhaurlin commented 6 years ago

That is true. For AP mode, no open source router supports MU-MIMO. For mwlwifi, we will port simple grouping rule to support MU-MIMO for AP mode.

tapper82 commented 6 years ago

Mu-Mimo is no good if we don't have stability!

adamcarter1 commented 6 years ago

I have stability.

tapper82 commented 6 years ago

On the wrt3200acm? The 5ghz is a crock and keeps changing chanels. the 2.4 ghz just stops ded and needs rebooting.

adamcarter1 commented 6 years ago

Yikes, i dont know your settings, or which firmware you are running. Buy my 3200acm dd-wrt build is stable, i dont use a lot of settings. Just vpn client, policy based routing, basically it. I also dont combine my 2.4ghz and 5 ghz into one ssid, like many folks do.

Regardless. I only need to reboot if my openvpn drops.

I grant you it isnt perfect, but, i dont have your problems.

yuhhaurlin commented 6 years ago

Current driver and firmware are pretty stable. Issues reported here will be checked after MU-MIMO is added. After MU-MIMO is added, I will check with our QA to clean issues reported here. However, it is better to report you issue with clear and precise descriptions. It should be reproducible with clear setup and steps.

supersebbo commented 6 years ago

5Ghz does change channels frequently for me, but this is due to DFS which is unavoidable. However I do feel that the radar detection is a little sensitive on this firmware, I have not seen it happen so much with the stock firmware. 2.4Ghz is rock solid however.

howl commented 6 years ago

@BrainSlayer MU-MIMO isn't supported in ip806x routers with ath10k driver?

Chadster766 commented 6 years ago

@BrainSlayer MU-MIMO is supported on Linux PC with the below hardware spec. In the old days wireless routers were just low profile Linux PC with wireless adapters. I don't think Marvell is the first to support MU-MIMO with there long development times.

https://www.snbforums.com/threads/qnap-wi-fi-adapter-adds-wireless-features-to-linux-based-nas-and-pcs.46800/

yuhhaurlin commented 6 years ago

What is the MU-MIMO grouping rule used by QNAP for AP mode? For ath10, it only supports MU-MIMO for client mode when I checked it last year. If you find ath10 supports MU-MIMO for AP mode, please let me know.

Chadster766 commented 6 years ago

Quote from: https://www.qnap.com/en/product/qwa-ac2600

The QWA-AC2600 supports Dual Band Dual Concurrent (DBDC) for acting as an access point or a base station, adding more possibilities to your investment.

BrainSlayer commented 6 years ago

@howl : the ath10k firmware blob does support it, but the ath10k driver does not.

BrainSlayer commented 6 years ago

@Chadster766 : sure the hw does support it and the windows drivers do support it as well, but ath10k does not

p3x-robot commented 6 years ago

3200acm is so low to buy, once mumimo is implemented, it will be so cheap, i love in it, just mumimo is not implemented, it will be in one two years done, then u can use it like 20 years, so little router with big antenna

Chadster766 commented 6 years ago

@BrainSlayer : The below document seems to indicate that ath10k has mu-mimo with hostapd

https://wireless.wiki.kernel.org/en/users/drivers/ath10k/configuration#mu-mimo_configuration

eduperez commented 6 years ago

Perhaps we should stop arguing about what other drivers can o cannot do, and focus on this one.

Chadster766 commented 6 years ago

@eduperez : We aren't arguing as far as I know. Just discussing mu-mimo. You never know maybe the ath10k source code could help speed this drivers development and stability.

BrainSlayer commented 6 years ago

@Chadster766 : this just enables the vht cap flags for mu-mimo, but you need more than just this to run mu-mimo. this is just tx beamforming for mu-mimo. i have also seen the firmware crashing if you run mu-mimo for rx

yuhhaurlin commented 6 years ago

Yes. MU-MIMO needs explicit beamforming: VHT sounding protocol. Except for that, you still needs rule to group MU clients for AP mode.

BrainSlayer commented 6 years ago

@yuhhaurlin : thanks for further explanation

yuhhaurlin commented 6 years ago

In fact, I already get enough information to implement MU-MIMO for mwlwifi with simple static grouping rule. Thanks for all your information.

adamcarter1 commented 6 years ago

Ok, we have waited long enough. Please yuhhaurlin give us the power.... the power of mu-mimo..

p3x-robot commented 6 years ago

hey, he will do it, goes other work as well, i was inpatient as well. just let him be,

davidc502 commented 6 years ago

I'm not sure what kind of a difference people are expecting with mu-mimo. I hope they aren't expecting too much because they are likely to be disappointed.

p3x-robot commented 6 years ago

We cannot even use it the bandwidth with MU-MIMO, unless u are in business but then you probable use Cisco and not OpenWrt. It will be on time. I GUESS.

adamcarter1 commented 6 years ago

Hey david i agree with you.

It’s just that i paid for a router when it first came out that touted open-source ready and mu-mimo almost 2 years ago. And i kinda like to get what was advertised. I paid for it. We all did.

PalebloodSky commented 6 years ago

@davidc502 fair enough but it would be an improvement and be great exposure for the Linksys WRT series to be the first OpenWrt router with MU-MIMO. It would almost make up for the absolutely horrific support they had most of 2017. Things are finally shaping up to be in a good place open source wise.

BrainSlayer commented 6 years ago

@PalebloodSky and DD-WRT :-)

p3x-robot commented 6 years ago

but guys, can we use up all that MU-MIMO bandwidth??? so few MU-MIMO wifi cards, right? by the time it is implemented, it will be available everywhere, so it is not a problem now, isnt it?

p3x-robot commented 6 years ago

if you want to sell your 3200ACM i buy it! it is still the 2nd best!!!

PalebloodSky commented 6 years ago

@BrainSlayer yes and thanks for all your hard work on DD-WRT, it's run great on my R7000 for a while now. For my WRT32X using OpenWRt 18.06 :)

Skilmatix commented 6 years ago

@BrainSlayer, is there a plan to support 802.11r on DD-WRT? That’s the only reason I switched to LEDE. And thanks for all your work on the firmware. I’ve enjoyed them both.

BrainSlayer commented 6 years ago

@Skilmatix i recently released a working version for the WRT32X. originally a version was available since a long time but only flashable by commandline. the linksys gui has a file size restriction so i was able to create a overtake image for dd-wrt as well. which can be flashed as initial image with limited features. then you can upgrade to the full version. its basicly identical with the wrt3200acm version since the hw is identical and its always up to date with drivers unlike openwrt

BrainSlayer commented 6 years ago

but its no debian style system for sure. its designed for use as is, but has a commandline for custom things. but not that flexible as openwrt. but robust

BrainSlayer commented 6 years ago

@Skilmatix 802.11r was not big thing they. i dont believe in mesh. its more like a low performance use as is system and its also not supported by all chipsets. i believe more in dedicated long range links and local ap installations. i played with 802.11r but never found any use in it. performance sucks for professional applications

Skilmatix commented 6 years ago

@BrainSlayer: got it and thanks!

jukkapirinen commented 6 years ago

802.11r just enables faster roaming between APs helping in voip or ssh apps not disconneting. Authentication is done already in reassoc request / response, so 4-way handshake not required. I find it working very well if client supports it.

Ath9/10k and mwlwifi supports it, most popular chipsets used with opensource firmware.

Sorry for off topic.

PalebloodSky commented 6 years ago

@BrainSlayer yes I've been running davidc502's build of OpenWrt Master which has the latest drivers. Ran DD-WRT on my R7000 and you do great work, but decided at least for the time being to go OpenWrt on my new WRT32X. I really like this router (overall look, performance, etc.) I hope open source development for it continues.

BrainSlayer commented 6 years ago

@bbogey you mean fast transission. this is basicly no problem to implement in dd-wrt. the curious thing is that i never had issues with roaming even with normal wpa authentication. seamless handover can be handled by the client without connection loss. dont know if it really is usefull. but might be for some people. but another problem is the constent code increase in hostapd and wpa supplicant and i still have to support smaller devices. its not just about the wrt1900 series

jukkapirinen commented 6 years ago

Yes, I mean fast bss transition. Yes also in openwrt it requires full wpad to have it working.

My OnePlus doesn't support fast bss transition, but still while roaming it is not disconneting. But for example iPad air 2 SSH gets disconnected while roaming without 802.11r enabled. I haven't tested for a while without, it might not be the case anymore.

adamcarter1 commented 6 years ago

I knew this wasn’t going to get finished.

Also brainslayer. The world is waiting for you to fix problem 6319 on svn timeline. Thanks in advance.

adamcarter1 commented 6 years ago

Looks like 802.11 ax comes out in september with asus rog gt-11000. I think i was correct when i said this wouldn’t get fixed before 802.11ax .

thagabe commented 6 years ago

It's September my dudes! I am still scratching my head as to what the recent commits have to do with adding features/fixing bugs, but who knows anymore.

PalebloodSky commented 6 years ago

Sadly they don't Linksys lied and doesn't support their routers like they claim. They haven't' even updated the stock firmware in 6+ months let alone supporting open source.

s-pimenta commented 6 years ago

I'm tired of waiting and waiting... Please finish the backlog of 88W8864 and do not pass to 88W8997!

You are tring to let old things to die and be forgotten...

Support from Marvell is horrendous! They will pass to 88W8997 and also not finish all the features...

So all in the end Marvell support is all of incomplete drivers...

Maybe I will sell my WRT3200ACM and still get some money back...