Windows actions use a weird rule to decide which file to attach the action to, we should do something smarter

kalsbold / gyp

Automatically exported from code.google.com/p/gyp

0 stars 0 forks source link

Windows actions use a weird rule to decide which file to attach the action to, we should do something smarter #44

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago

Currently since actions in msvs need to be attached to a particular file,
we pick the second file in the list, unless there is only one.
This works ok, but is a hack.
We should fix it.

Original issue reported on code.google.com by bradnel...@google.com on 9 Jul 2009 at 7:43

GoogleCodeExporter commented 9 years ago

A slightly better solution would be to somehow determine which input file 
uniquely 
determines the action.  The current rule works in practice for Chromium, but 
isn't 
general.

Original comment by sgk@chromium.org on 6 Aug 2009 at 6:42

GoogleCodeExporter commented 9 years ago

Original comment by sgk@chromium.org on 18 Aug 2009 at 8:06

Added labels: MSVS

GoogleCodeExporter commented 9 years ago

At the very least we should have an error message for collisions on this.

Original comment by bradnelson@google.com on 29 Apr 2010 at 9:03

Added labels: Priority-High
Removed labels: Priority-Medium

GoogleCodeExporter commented 9 years ago

This just bit the o3d guys, twice. We should really at least at the error 
message.

Original comment by bradnelson@google.com on 21 Jun 2010 at 6:35