GYP_GENERATORS only process the first item

[GoogleCodeExporter]

What steps will reproduce the problem?
1. export GYP_GENERATORS=make scons
2. gclient sync

What is the expected output? What do you see instead?
http://falconpastebin.appspot.com/44009
It only generated the make projects, not the scons ones.

Original issue reported on code.google.com by maruel@chromium.org on 10 Aug 2009 at 3:26

[GoogleCodeExporter]

Did you quote it so that everything went into GYP_GENERATORS?

mark@anodizer bash$ export GYP_GENERATORS="xcode make"
mark@anodizer bash$ echo ${GYP_GENERATORS}
xcode make
mark@anodizer bash$ gclient sync
[...]
mark@anodizer bash$ date
Mon Aug 10 12:05:40 EDT 2009
mark@anodizer bash$ ls -l build/all.xcodeproj/project.pbxproj Makefile 
-rw-------  1 mark  staff   10716 Aug 10 12:04 Makefile
-rw-------  1 mark  staff  180678 Aug 10 12:04 
build/all.xcodeproj/project.pbxproj

Original comment by mark@chromium.org on 10 Aug 2009 at 4:05

[GoogleCodeExporter]

The export line is wrong.  POSIX export requires that arguments containing 
white 
space are quoted.  The above just set GYP_GENERATORS to "make" and exported a 
separate "scons" variable (which would happen to be whatever value $scons is 
set to 
in your environment, almost certainly empty).

The quoting requirement is a pain.  I'd prefer it if we'd allow the generators 
to be 
white space *or* comma separated:

GYP_GENERATORS=make,scons

I'll work up  a patch for that.

Original comment by sgk@chromium.org on 10 Aug 2009 at 4:12

[GoogleCodeExporter]

Fixed in r589.

Original comment by sgk@chromium.org on 21 Oct 2009 at 5:33

• Changed state: Fixed