search

kaltura / EmbedCodeGenerator

Kaltura Embed Code generator library.
http://kaltura.github.com/EmbedCodeGenerator
7 stars 13 forks source link

Include option to switch between html5 and flash players #6

Open mdale opened 11 years ago

mdale commented 11 years ago

we should include a option to easily switch between html5 and flash players.

ranyefet commented 11 years ago

What do you mean? I didn't understand the issue. Which player to load is defined in the uiConf by uiVars Do you want that the embed code generator will add: mw.setConfig('forceHTML5', true);

mdale commented 11 years ago

yes the option to force HTML5 from the interface maybe ~above~ the iframe. ( not the normal ?forceMobileHTML5 does not work because the embed code is in an iframe

ranyefet commented 11 years ago

But what is the use case?

mdale commented 11 years ago

To be able to easily preview the html5 player without having to change your user agent? ... I think it would be worth while to put into the kmc preview and embed in some future cycle as well. As long as the ui is clear that your just previewing the other player not setting any property on the player it self.

zoharbabin commented 11 years ago

@ranyefet - @mdale is submitting a feature request not reporting a bug :) I agree, we should certainly add a button that switches between html5 and flash preview, especially in the KMC Preview & Embed window, I find myself frequently loading the preview link and adding ?forceMobileHTML5 to the url just to see HTML5 preview.

ranyefet commented 11 years ago

I see the use case but I don't think it should be part of the EmbedCodeGenerator. What I'm suggesting is that we will add the ability to "leadWithHTML5" using flash var. And that will solve the problem in the most elegant way.

mdale commented 11 years ago 
Sure.. it should be part of the "demo"
  or "preview and embed" invocation, not the embedCodeGenerator
  itself. We just want to expose the option to "preview" the html5
  player. Which is different from having your embed code lead with
  html5. 
  On 02/23/2013 04:42 AM, Ran Yefet wrote:

  I see the use case but I don't think it should be part of the
    EmbedCodeGenerator.
    What I'm suggesting is that we will add the ability to
    "leadWithHTML5" using flash var.
    And that will solve the problem in the most elegant way.

    —
    Reply to this email directly or view
      it on GitHub.