search

kaltura / KalturaGeneratedAPIClientsPython

Python auto generated clients libs which will then be built and test by Travis CI
GNU Affero General Public License v3.0
6 stars 15 forks source link

Use tox and pytest to run tests #2

Closed ccorbacho closed 6 years ago

ccorbacho commented 6 years ago

Use pytest as the test discoverer, which is much more sophisticated than the basic unittest runner, and has a lot more features, like coverage reporting (now enabled).

Use tox to take care of running pytest with the correct parameters and trigger that from Travis instead of running the test runner directly (the tox-travis plugin ensures tox does not complain about missing Python versions when run in an environment with only one version).

ccorbacho commented 6 years ago

@jessp01 Can you take a look at this one?

Also, I've added pycrypto to requirements.txt here as your KSv2 changes in https://github.com/kaltura/clients-generator/commit/435c95ebb1ddfa34b962011effa97dd46a547428 broke the tests - I haven't added it to setup.py, unless you want to make it required now and drop the KsV1 path?

kaltura-hooks commented 6 years ago

Hi @ccorbacho, Thank you for contributing this pull request! The KalturaGeneratedAPIClientsPython is autogenerated from https://github.com/kaltura/clients-generator under sources/LANG Please create a new pull on the server repo.

jessp01 commented 6 years ago

Hi @ccorbacho,

Use of generateSession() [KSv1] is still valid so no need to add pycrypto to setup.py [which is only needed for generateSessionV2()], adding it to requirements.txt [so that the Travis CI run will succeed] is the correct thing to do.

We may want to add a note about it in the README, however, I'll take care of that.

I merged the request and thanks!