search

kaltura / all-in-one-video-pack.wordpress

A Wordpress Plugin to simplify adding Kaltura to your Blog
https://wordpress.org/plugins/all-in-one-video-pack/
19 stars 31 forks source link

Upgrade Kaltura client library to latest #59

Closed rkreich closed 7 years ago

rkreich commented 7 years ago

Created out of https://github.com/kaltura/all-in-one-video-pack.wordpress/pull/56

Kaltura client library used by WordPress plugin needs to be updated to latest version. When generating new PhpZendClientGenerator using the following config https://github.com/kaltura/all-in-one-video-pack.wordpress/blob/master/lib/Kaltura/client-generation-readme.txt and the latest code of clients-generator (https://github.com/kaltura/clients-generator), it produces huge diff.

A few issues:

Client lib code needs to stay minimal to have the plugin compatible with VIP.

rkreich commented 7 years ago

@jessp01 - I've added the needed options to client-generator repo (see https://github.com/kaltura/clients-generator/pull/170), to allow generating new API client libraries for WordPress. Can you create a github repo for it? As discussed on https://github.com/kaltura/all-in-one-video-pack.wordpress/pull/56. (config/generator.ini was updated). Thanks

jessp01 commented 7 years ago

Hi @rkreich, sure. As soon as @tan-tan-kanarek merges https://github.com/kaltura/clients-generator/pull/170/files. Also, add wordpress here: https://github.com/kaltura/clients-generator/blob/Mercury-13.2.0/config/generator.all.ini

jessp01 commented 7 years ago

Done, see https://github.com/kaltura/KalturaGeneratedAPIClientsWordpress

rkreich commented 7 years ago

Thanks. I've updated the client library on https://github.com/kaltura/all-in-one-video-pack.wordpress/pull/74 Closing issue.