kaltura / all-in-one-video-pack.wordpress

A Wordpress Plugin to simplify adding Kaltura to your Blog
https://wordpress.org/plugins/all-in-one-video-pack/
20 stars 32 forks source link

Editor's sticky header wrongly positioned #82

Open carlosesilva opened 7 years ago

carlosesilva commented 7 years ago

Hello there,

I work for Boston University and we are in the process of integrating your plugin into our platform.

We have found an issue where the editor's header (sometimes the footer as well) gets absolute positioned in a weird spot. It happens if a post has enough content to trigger the editor's header sticky mode when you scroll down the edit page.

This issue was confirmed to happen on a fresh install of WordPress with only the all-in-one-video-pack plugin installed (confirmed on both v2.7 and v2.8-rc.4).

We have found that the issue gets fixed when we remove the css rule body{ overflow: auto; } found here: https://github.com/kaltura/all-in-one-video-pack.wordpress/blob/master/css/admin.css#L4

I don't see why a plugin would need to add styles to the html and body tags anyways. Unless there is a very good reason to have them, I believe those styles should be removed so that this issue gets fixed. I will be submitting a pull request shortly after this with the proposed fix. In the mean time I will be adding some more information about the issue below.

How to reproduce the issue

  1. Activate all-in-one-video-pack.
  2. Go edit a post that has a lot of content (enough that you need to scroll down to see it all).
  3. Scroll down so that the editor's header enters the sticky mode.
  4. Scroll up to the top of the page. The editor should appear broken now.

Screenshots of the issue in action

Visual view kaltura-broken-editor-visual Text view kaltura-broken-editor-text

Environment tested on

kaltura-hooks commented 7 years ago

Hi @carlosesilva,

Thank for you reporting an issue and helping improve Kaltura!

To get the fastest response time, and help the maintainers review and test your reported issues or suggestions, please ensure that your issue includes the following (please comment with more info if you have not included all this info in your original issue):

For general troubleshooting see: https://github.com/kaltura/platform-install-packages/blob/Jupiter-10.13.0/doc/kaltura-packages-faq.md#troubleshooting-help

If you only have a general question rather than a bug report, please close this issue and post at: http://forum.kaltura.org

Thank you in advance,