kaltura / kme-sdk-android

Kaltura Meeting Experience SDK for Android
GNU Affero General Public License v3.0
2 stars 2 forks source link

Preview Camera dialog is clipped in landscape mode #150

Open flamyoad opened 3 years ago

flamyoad commented 3 years ago

The bottom-half of the camera preview dialog are not shown in landscape mode.

The height of the dialog seems to be hardcoded. I'm hoping this will be fixed in the future version.

Portrait mode: 1

Landscape mode: (Notice how the 'OK' button and the mic/camera buttons got clipped out of screen) 2

    <com.kme.kaltura.kmesdk.webrtc.view.KmeSurfaceRendererView
        android:id="@+id/preview"
        android:layout_width="300dp"
        android:layout_height="0dp"
        android:layout_marginTop="32dp"
        android:layout_marginBottom="6dp"
        android:background="@drawable/rounded_inside_corners"
        app:layout_constraintBottom_toBottomOf="parent"
        app:layout_constraintBottom_toTopOf="@+id/controlsContainer"
        app:layout_constraintDimensionRatio="9:16"
        app:layout_constraintEnd_toEndOf="parent"
        app:layout_constraintStart_toStartOf="parent"
        app:layout_constraintTop_toBottomOf="@+id/tvTitle" />

Seems that the only way is to reduce the layout_width because the ratio is fixed to 9:16 in the landscape xml. But I'm hoping for a more elegant solution from official team.

kaltura-hooks commented 3 years ago

Hi @flamyoad,

Thank for you reporting an issue and helping improve Kaltura!

To get the fastest response time, and help the maintainers review and test your reported issues or suggestions, please ensure that your issue includes the following (please comment with more info if you have not included all this info in your original issue):

For general troubleshooting see: https://github.com/kaltura/platform-install-packages/blob/Jupiter-10.13.0/doc/kaltura-packages-faq.md#troubleshooting-help

If you only have a general question rather than a bug report, please close this issue and post at: http://forum.kaltura.org

Thank you in advance,