kaltura / moodle_plugin

8 stars 37 forks source link

implement moodle global search #314

Open yedidiaklein opened 3 years ago

yedidiaklein commented 3 years ago

Why didn't you implemented global search on your modules ? at least on the basic video module. see : https://docs.moodle.org/dev/Search_API

This is very important!! Tnx

idodido commented 3 years ago

hi @yedidiaklein

can you elaborate on the need and your suggested solution? what is the suggested flow?

yedidiaklein commented 3 years ago

Hi, @idodido

Added basic support on 3 mods on branch moodle37. here is my pull request: https://github.com/kaltura/moodle_plugin/pull/315

Of course it could be implemented on other branches..

Tnx a lot!

yedidiaklein commented 3 years ago

Hi,

Any news with the pull request ? do you want me to add it also to other branches ?

tnx a lot!

idodido commented 3 years ago

hi @yedidiaklein Appreciate your work on this. please note that no new plugin version is scheduled at the moment. new plugin versions are released periodically, as it requires resources scheduling.

Also, before adding the pull request, i would like to get an understanding of what exactly is this adding. what type of support for global search? where?

it you rather, we can wait for one of the developers to be assigned and look at it, but that might take a while. and so in order to approve the efforts on this, i would like to understand if this feature is compatible with the product roadmap and vision.

thanks ido.

yedidiaklein commented 3 years ago

Moodle has a feature of global search on all site. Every module need to implement indexing to this search, If your module isn't implementing indexing - it won't be found in global search. Most of Universities/Colleges that I know do not implement global search at all. But, some do...

It's so simple to implement, so it should be the standard on any module... Specifically, I've a client that use Kaltura and is missing this feature.

Of course I could implement it on his site, but I would like it to be on your baseline for future versions.

Tnx,