search

kaltura / moodle_plugin

8 stars 37 forks source link

Kaltura media assignment errors #422

Open haietza opened 3 months ago

haietza commented 3 months ago

Testing version Kaltura release 4.4.8 2023100901 of the plugins on PHP 8.1 with Moodle 4.3 and get the following errors:

Invalid event functions defined in \mod_kalvidassign\event\assignment_details_viewed

line 275 of /lib/classes/event/base.php: call to debugging()
line 53 of /mod/kalvidassign/view.php: call to core\event\base::create()

Deprecated: Optional parameter $groupfilter declared before required parameter $perpage is implicitly treated as a required parameter in /var/www/asulearn-test.appstate.edu/mod/kalvidassign/renderer.php on line 719

haietza commented 3 months ago

Also the following on the grade submissions page:

Invalid event functions defined in \mod_kalvidassign\event\grade_submissions_page_viewed

line 275 of /lib/classes/event/base.php: call to debugging()
line 66 of /mod/kalvidassign/grade_submissions.php: call to core\event\base::create()

user_picture::fields() is deprecated. Please use the \core_user\fields API instead.

line 257 of /lib/outputcomponents.php: call to debugging()
line 865 of /mod/kalvidassign/renderer.php: call to user_picture::fields()
line 221 of /mod/kalvidassign/grade_submissions.php: call to mod_kalvidassign_renderer->display_submissions_table()

Deprecated: strip_tags(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/html/mod/kalvidassign/renderer.php on line 214

Deprecated: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated in /var/www/html/local/kaltura/locallib.php on line 241 Invalid get_string() identifier: 'grade' or component 'moodle'. Perhaps you are missing $string['grade'] = ''; in lang/en/moodle.php?

line 356 of /lib/classes/string_manager_standard.php: call to debugging()
line 7515 of /lib/moodlelib.php: call to core_string_manager_standard->get_string()
line 369 of /mod/kalvidassign/renderer.php: call to get_string()
line 861 of /lib/tablelib.php: call to submissions_table->col_status()
line 2087 of /lib/tablelib.php: call to flexible_table->format_row()
line 2211 of /lib/tablelib.php: call to table_sql->build_table()
line 908 of /mod/kalvidassign/renderer.php: call to table_sql->out()
line 221 of /mod/kalvidassign/grade_submissions.php: call to mod_kalvidassign_renderer->display_submissions_table()

The call to get_string is incorrect in renderer.php:369. I needs the component argument; either 'grades' for Moodle core lang pack or 'kalvidassign' for KVA lang pack.

ctam commented 1 month ago

Testing version Kaltura release 4.4.8 2023100901 of the plugins on PHP 8.1 with Moodle 4.3 and get the following errors:

Invalid event functions defined in \mod_kalvidassign\event\assignment_details_viewed

line 275 of /lib/classes/event/base.php: call to debugging()
line 53 of /mod/kalvidassign/view.php: call to core\event\base::create()

Deprecated: Optional parameter $groupfilter declared before required parameter $perpage is implicitly treated as a required parameter in /var/www/asulearn-test.appstate.edu/mod/kalvidassign/renderer.php on line 719

Just want to put a little context to this error. These functions had been deprecated completely in Moodle 4.3 on:

get_legacy_logdata set_legacy_logdata get_legacy_eventname get_legacy_eventdata

See https://github.com/moodle/moodle/blob/v4.3.4/lib/classes/event/base.php#L270-L276

They should be removed from all kaltura's classes.