search

kaltura / mwEmbed

Kaltura's Cross Platform Video Player ToolKit
http://player.kaltura.com
GNU Affero General Public License v3.0
210 stars 137 forks source link

JSHint and JSCS mwEmbed codebase #1270

Open hartman opened 9 years ago

hartman commented 9 years ago

There is a statement in the readme that the code follows mediawiki code conventions, but that is far from true :)

I have started a jscleanup branch on hartman/mwEmbed with that exact goal in mind. I have so far taken care of initial setup and making TimedText pass this setup. The final goal for me is to improve the next attempt of bringing the MW and Kaltura versions closer together again and easier to maintain.

hartman commented 9 years ago

TODO list of non-obvious/dangerous jshint problems in my 'cleaned' branch.

modules/TimedText/resources/mw.TextSource.js: line 80, col 17, Do not use 'new' for side effects.

modules/MwEmbedSupport/jquery/jquery.mwMessage.js: line 80, col 72, 'match' is not defined.

modules/MwEmbedSupport/jquery.loadingSpinner/jquery.loadingSpinner.js: line 81, col 35, Variables should not be deleted.

modules/MwEmbedSupport/mediawiki/mediawiki.UtilitiesUrl.js: line 37, col 50, 'src' is not defined.

modules/MwEmbedSupport/mw.MwEmbedSupport.js: line 195, col 13, Do not use 'new' for side effects.

itaykinnrot commented 9 years ago

Thanks @hartman I'm adding @OrenMe (one of our developers) who will help to include the jshint to our build.