kaltura / mwEmbed

Kaltura's Cross Platform Video Player ToolKit
http://player.kaltura.com
GNU Affero General Public License v3.0
210 stars 137 forks source link

Simplify our Fullscreen code #410

Open ranyefet opened 11 years ago

ranyefet commented 11 years ago

Our current Fullscreen code is quite bad. I suggest we move the fullscreen code into separate files which will handle all fullscreen code.

That file will use screenfull.js https://github.com/sindresorhus/screenfull.js/ behind the scenes and will have fallback to DOM resize.

mdale commented 11 years ago

does it also support friendly iframe expansion?

mdale commented 11 years ago

we should also look at cross-domain fullscreen. we should call dom fullscreen on the outer div.. not the outer iframe. i.e so that if the allowFullscreen attribute is set we can still enter dom fullscureen on thouse cross domain included iframes