fix(FEC-11887): qna container is not visible on embedded player by default if the uivar “Kaltura.ForceLayoutRedraw” is set to true

kaltura / mwEmbed

Kaltura's Cross Platform Video Player ToolKit

http://player.kaltura.com

GNU Affero General Public License v3.0

210 stars 137 forks source link

fix(FEC-11887): qna container is not visible on embedded player by default if the uivar “Kaltura.ForceLayoutRedraw” is set to true #4257

Closed lianbenjamin closed 2 years ago

lianbenjamin commented 2 years ago

the issue: this is a regression caused by SUP-11362. when uivar Kaltura.ForceLayoutRedraw=true and using qna plugin where onPage=false, the qna container is not visible when the player is loaded.

the solution: executing the responsive action that was added by SUP-11362 only in 2 cases:

when there is no qna plugin/disabled.
if qna plugin exists and enabled, then only when onPage=true.

Solves FEC-11887

PlaykitJs-Bot commented 2 years ago

Live Pull Request Urls

Library version ID: 2.92__03b7fb75 ( last commit: 03b7fb7587616b0922565df65a2cefb862f70272 )
Feature list docs -- Feature list for this pull request
mwEmbedLoader url -- For testing custom players

PlaykitJs-Bot commented 2 years ago

Updated pull request 4257: 0d1ee83e87557b0683b1d1f291d2929375e4f4c4

Library version ID: 0d1ee83e__0d1ee83e ( last commit: 0d1ee83e87557b0683b1d1f291d2929375e4f4c4 )
Feature list docs -- Feature list for this pull request
mwEmbedLoader url -- For testing custom players