kaltura / nginx-vod-module

NGINX-based MP4 Repackager

GNU Affero General Public License v3.0

1.98k stars 439 forks source link

HLS name attribute for links to master files #1016

Open ppllaxxa opened 5 years ago

ppllaxxa commented 5 years ago

Is it possible to add NAME attribute to directives like in example below? The value will be level of video quality.

EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=2149280,CODECS="mp4a.40.2,avc1.64001f",RESOLUTION=1280x720,NAME="720"

url_0/193039199_mp4_h264_aac_hd_7.m3u8

EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=246440,CODECS="mp4a.40.5,avc1.42000d",RESOLUTION=320x184,NAME="240"

url_2/193039199_mp4_h264_aac_ld_7.m3u8

EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=460560,CODECS="mp4a.40.5,avc1.420016",RESOLUTION=512x288,NAME="380"

url_4/193039199_mp4_h264_aac_7.m3u8

EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=836280,CODECS="mp4a.40.2,avc1.64001f",RESOLUTION=848x480,NAME="480"

url_6/193039199_mp4_h264_aac_hq_7.m3u8

EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=6221600,CODECS="mp4a.40.2,avc1.640028",RESOLUTION=1920x1080,NAME="1080"

url_8/193039199_mp4_h264_aac_fhd_7.m3u8

erankor commented 5 years ago

Unless I'm missing something, there is no such thing in the HLS spec, NAME exists only for EXT-X-MEDIA. If the goal is to identify which rendition is playing on the player side, you can instead enable ID3 tags (vod_hls_mpegts_output_id3_timestamps). The ID3 tags contain the sequence id provided to nginx-vod-module.