kaltura / nginx-vod-module

NGINX-based MP4 Repackager
GNU Affero General Public License v3.0
1.99k stars 439 forks source link

Unable to compile after latest PR #1456

Closed francoism90 closed 11 months ago

francoism90 commented 1 year ago
/usr/local/src/nginx-vod-module/vod/filters/audio_filter.c: In function 'audio_filter_init_source':
/usr/local/src/nginx-vod-module/vod/filters/audio_filter.c:318:17: error: 'channel_layout' is deprecated [-Werror=deprecated-declarations]
  318 |                 decoder->channel_layout);
      |                 ^~~~~~~
In file included from /usr/local/src/nginx-vod-module/vod/filters/../input/../common.h:115,
                 from /usr/local/src/nginx-vod-module/vod/filters/../input/read_cache.h:5,
                 from /usr/local/src/nginx-vod-module/vod/filters/../input/frames_source.h:5,
                 from /usr/local/src/nginx-vod-module/vod/filters/../media_format.h:5,
                 from /usr/local/src/nginx-vod-module/vod/filters/../media_set.h:5,
                 from /usr/local/src/nginx-vod-module/vod/filters/audio_filter.h:5,
                 from /usr/local/src/nginx-vod-module/vod/filters/audio_filter.c:1:
/usr/include/libavcodec/avcodec.h:1060:14: note: declared here
 1060 |     uint64_t channel_layout;
      |              ^~~~~~~~~~~~~~
/usr/local/src/nginx-vod-module/vod/filters/audio_filter.c: In function 'audio_filter_alloc_state':
/usr/local/src/nginx-vod-module/vod/filters/audio_filter.c:735:52: error: 'AVFilterLink' has no member named 'channels'
  735 |                 encoder_params.channels = sink_link->channels;
      |                                                    ^~
/usr/local/src/nginx-vod-module/vod/filters/audio_filter.c:736:17: error: 'channel_layout' is deprecated [-Werror=deprecated-declarations]
  736 |                 encoder_params.channel_layout = sink_link->channel_layout;
      |                 ^~~~~~~~~~~~~~
In file included from /usr/local/src/nginx-vod-module/vod/filters/audio_filter.c:6:
/usr/include/libavfilter/avfilter.h:558:14: note: declared here
  558 |     uint64_t channel_layout;
      |              ^~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [objs/Makefile:1727: objs/addon/filters/audio_filter.o] Error 1
make[1]: Leaving directory '/usr/local/src/nginx'
make: *** [Makefile:10: build] Error 2

Is it possible to ignore -Werror=deprecated-declarations somehow?

francoism90 commented 1 year ago

Hmm, it does work when using ffmpeg4, instead of the latest version.

But I thought the PR would fix the compile issue on newer versions. :)

francoism90 commented 11 months ago

This seems to fixed by https://github.com/kaltura/nginx-vod-module/commit/24c778fc350ce41e71583c8a74eedfd197154eb7

Thanks!