Non accurate DFXP subtitles.

kaltura / nginx-vod-module

NGINX-based MP4 Repackager

GNU Affero General Public License v3.0

1.99k stars 439 forks source link

Non accurate DFXP subtitles. #1483

Open tomstolarczuk opened 11 months ago

tomstolarczuk commented 11 months ago

Hello! We've noticed that WebVTT captions are a bit misaligned compared to what is declared in original XML file. Looking at the dfxp_format.c parser code, it defines framerate as constant 30fps (DFXP_FRAME_RATE). Are there any plans to support different framerates (eg. by reading ttp:frameRate property)?

Also: do you accept PRs?

Greetings, Tom

erankor commented 11 months ago

This makes sense, I think I just wasn't familiar with this property when I wrote this... a PR is welcome