Upstream error handling

kaltura / nginx-vod-module

NGINX-based MP4 Repackager

GNU Affero General Public License v3.0

2k stars 439 forks source link

Upstream error handling #1533

Closed SebastienChauvin closed 4 months ago

SebastienChauvin commented 4 months ago

propagate upstream http code when upstream returns NGX_HTTP_BAD_REQUEST, NGX_HTTP_NOT_FOUND, NGX_HTTP_FORBIDDEN, NGX_HTTP_GONE
include upstream uri in error log

Fix #468

kaltura-hooks commented 4 months ago

Hi @SebastienChauvin, Thank you for contributing this pull request! Please sign the Kaltura CLA so we can review and merge your contribution. Learn more at http://bit.ly/KalturaContrib

SebastienChauvin commented 3 months ago

Hello @erankor, did I miss something ? Is there a preferred way to have a discussion around the PR ?

erankor commented 3 months ago

I didn't understand why you chose those 4 specific status codes. If anything, I'd add a configurable list of status codes, as I did in our live packager - https://github.com/kaltura/media-framework/tree/master/nginx-pckg-module#pckg_pass_codes
I'm quite sure the URI is already printed by the base logger, I think only the status code should be logged here
The indentation doesn't match the existing code

SebastienChauvin commented 3 months ago

Thanks for the feedback